Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "revert" instead of "reverse" in Git context #32197

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Use "revert" instead of "reverse" in Git context #32197

merged 2 commits into from
Mar 25, 2024

Conversation

hsnabszhdn
Copy link
Contributor

@hsnabszhdn hsnabszhdn commented Mar 24, 2024

Why:

There is only 3 places in the repository that uses "reverse" when talking in Git commits context, and a lot more using "revert".

I'm changing the 2 out of these 3 places to match the rest of the repository. I think the third places was supposed to be the definition of the term "revert" and using "reverse" makes sense there(?), but if you think that also needs to change, happy to update that as well:

Options for managing commits in GitHub Desktop

image

Closes: N/A

What's being changed (if available, include any code snippets, screenshots, or gifs):

The verb "reverse" changes to "revert" when talking about Git commits.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 24, 2024
Copy link
Contributor

github-actions bot commented Mar 24, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/available-rules-for-rulesets.md fpt
ghec
ghes@ 3.12 3.11
fpt
ghec
ghes@ 3.12 3.11

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836
Copy link
Contributor

@itecompro Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

supposed to be the definition of the term "revert" and using "reverse" makes sense there

Agreed - we're aligned on this 💛

@nguyenalex836 nguyenalex836 enabled auto-merge March 25, 2024 15:16
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Mar 25, 2024
Merged via the queue into github:main with commit d94a9aa Mar 25, 2024
39 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@hsnabszhdn hsnabszhdn deleted the fix/use-revert-instead-of-reverse-in-git-context branch March 25, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants