Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boldface for clickable UI elements #32201

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Use boldface for clickable UI elements #32201

merged 3 commits into from
Mar 25, 2024

Conversation

hsnabszhdn
Copy link
Contributor

@hsnabszhdn hsnabszhdn commented Mar 24, 2024

Why:

Using quotation marks does not follow the style guide:

Use bold to describe UI elements that can be interacted with

Closes: N/A

What's being changed (if available, include any code snippets, screenshots, or gifs):

Click "SOMETHING" changes to Click **SOMETHING**

Check off the following:

  • ❌ I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

    ❌ The first deployment got interrupted by a force push and failed 🤦, and now no new push triggers a proper preview environment for me to test 😕

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 24, 2024
@hsnabszhdn hsnabszhdn changed the title Use boldface for clickable UI elments Use boldface for clickable UI elements Mar 24, 2024
Copy link
Contributor

github-actions bot commented Mar 24, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
admin/identity-and-access-management/reconfiguring-iam-for-enterprise-managed-users/migrating-from-saml-to-oidc.md ghec
ghec
education/manage-coursework-with-github-classroom/teach-with-github-classroom/connect-a-learning-management-system-course-to-a-classroom.md fpt
fpt
migrations/using-github-enterprise-importer/completing-your-migration-with-github-enterprise-importer/troubleshooting-your-migration-with-github-enterprise-importer.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
repositories/viewing-activity-and-data-for-your-repository/using-the-activity-view-to-see-changes-to-a-repository.md fpt
ghec
ghes@ 3.12 3.11
fpt
ghec
ghes@ 3.12 3.11

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Mar 25, 2024
@nguyenalex836
Copy link
Contributor

@itecompro Thanks so much for opening a PR with these fixes! It looks like those deployment issues should be fixed now 🤞 I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Mar 25, 2024
Merged via the queue into github:main with commit 244e4cb Mar 25, 2024
38 of 39 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@hsnabszhdn hsnabszhdn deleted the fix/use-bold-face-for-clickable-ui-elements branch March 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants