Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update managing-accessibility-settings.md #34680

Closed

Conversation

HarshVardhan12102002
Copy link

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Sep 21, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 21, 2024
@subatoi
Copy link
Contributor

subatoi commented Sep 23, 2024

Thanks for your interest in the Docs—

These changes appear to be based around personal preference, and don't meet our style guide (that's also partly why the tests are failing). I'd recommend that you raise an issue first in future, so that we can discuss changes before you spend time writing them up. That way everybody—most importantly, you as the contributor—has a better overall experience.

You can also feel free to check out one of our issues marked help wanted.

@subatoi subatoi closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants