Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds periods to the end of each list line, as each line is a complete… #34958

Conversation

dr0er
Copy link
Contributor

@dr0er dr0er commented Oct 16, 2024

… sentence

Why:

Closes:

#34948 by @nguyenalex836

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

I added periods to the end of each list line, as each line is a complete sentence - due to request in an issue mentioned above.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Oct 16, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/developing-in-a-codespace/persisting-environment-variables-and-temporary-files.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels Oct 16, 2024
@nguyenalex836
Copy link
Contributor

@dr0er Thank you so much for opening a PR! ✨ May we ask why you changed the single quotes to double quotes? The rest of our docs use single quotes, and we'd love to maintain consistency 💛

@nguyenalex836 nguyenalex836 added the more-information-needed More information is needed to complete review label Oct 16, 2024
@nguyenalex836
Copy link
Contributor

@dr0er I went ahead and reverted back to single quotes! 💛 Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

…t-variables-and-temporary-files#for-all-codespaces-for-a-repository#34948
@nguyenalex836 nguyenalex836 removed the more-information-needed More information is needed to complete review label Oct 17, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into github:main with commit 6174d46 Oct 17, 2024
46 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Aranmobinarann

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team
Projects
None yet
3 participants