Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo sync #35488

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update to the note and add note to all impacted versions (#53363)
donal authored Nov 29, 2024
commit 7945947555b12cc01273124cd8fed98cd71d904c
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-13/0-rc1.yml
Original file line number Diff line number Diff line change
@@ -177,7 +177,7 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]

deprecations:
# https://github.com/github/releases/issues/2732
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-13/0.yml
Original file line number Diff line number Diff line change
@@ -190,7 +190,7 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]

deprecations:
# https://github.com/github/releases/issues/2732
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-13/2.yml
Original file line number Diff line number Diff line change
@@ -174,4 +174,4 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-13/3.yml
Original file line number Diff line number Diff line change
@@ -130,7 +130,7 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]

errata:
- |
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-13/4.yml
Original file line number Diff line number Diff line change
@@ -79,7 +79,7 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]

errata:
- 'The "[Known issues](/admin/release-notes#3.13.4-known-issues)" section previously indicated that `Instance setup in AWS with IMDSv2 enforced fails if no public IP is present` is still an issue. The issue is resolved and is documented in the "[Bug fixes](/admin/release-notes#3.13.4-bugs)" section. [Updated: 2024-09-30]'
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-13/5.yml
Original file line number Diff line number Diff line change
@@ -59,4 +59,4 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-13/6.yml
Original file line number Diff line number Diff line change
@@ -65,4 +65,4 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]
4 changes: 4 additions & 0 deletions data/release-notes/enterprise-server/3-13/7.yml
Original file line number Diff line number Diff line change
@@ -28,3 +28,7 @@ sections:
Services may respond with a `503` status due to an out of date `haproxy` configuration. This can usually be resolved with a `ghe-config-apply` run.
- |
Attempting to stop replications after stopping GitHub Actions on a GHES instanstance would fail, reporting that MSSQL was not responding. The can be avoided by start MSSQL prior to stopping replication `/usr/local/share/enterprise/ghe-nomad-jobs queue /etc/nomad-jobs/mssql/mssql.hcl`.
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-12-02]
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-14/0-rc1.yml
Original file line number Diff line number Diff line change
@@ -219,7 +219,7 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]

deprecations:
- |
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-14/0.yml
Original file line number Diff line number Diff line change
@@ -220,7 +220,7 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]

deprecations:
- |
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-14/1.yml
Original file line number Diff line number Diff line change
@@ -79,4 +79,4 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-14/2.yml
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]

deprecations:
- |
2 changes: 1 addition & 1 deletion data/release-notes/enterprise-server/3-14/3.yml
Original file line number Diff line number Diff line change
@@ -79,4 +79,4 @@ sections:
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-11-13]
[Updated: 2024-12-02]
4 changes: 4 additions & 0 deletions data/release-notes/enterprise-server/3-14/4.yml
Original file line number Diff line number Diff line change
@@ -38,3 +38,7 @@ sections:
Services may respond with a `503` status due to an out of date `haproxy` configuration. This can usually be resolved with a `ghe-config-apply` run.
- |
Attempting to stop replications after stopping GitHub Actions on a GHES instanstance would fail, reporting that MSSQL was not responding. The can be avoided by start MSSQL prior to stopping replication `/usr/local/share/enterprise/ghe-nomad-jobs queue /etc/nomad-jobs/mssql/mssql.hcl`.
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}

[Updated: 2024-12-02]
3 changes: 2 additions & 1 deletion data/release-notes/enterprise-server/3-15/0-rc1.yml
Original file line number Diff line number Diff line change
@@ -208,7 +208,8 @@ sections:
Customers doing feature version upgrade to 3.14.3 may experience issues with database migrations due to data issues during database conversions.
- |
{% data reusables.release-notes.2024-11-ghe-repl-promote-primary-down %}
[Updated: 2024-11-13]

[Updated: 2024-12-02]


closing_down:
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
When operating in a high availability configuration, running `ghe-repl-promote` on a replica node may fail if the original primary cannot be reached by the replica node. This is because the `ghe-repl-promote` script attempts to decommission all Elasticsearch nodes other than the promoted node, however these requests are made to the original primary node which is no longer reachable.
The error message will be similar to:
When operating in a high availability configuration, running `ghe-repl-promote` on a replica node will fail if the original primary cannot be reached by the replica node. This is because the `ghe-repl-promote` script attempts to decommission all Elasticsearch nodes other than the promoted node, however these requests are made to the original primary node which is no longer reachable. The error message written to the terminal will be similar to:

```shell
Maintenance mode has been enabled for active replica <REPLICA_HOSTNAME>
{"message": "No server is currently available to service your request. Sorry about that. Please try resubmitting your request and contact your local GitHub Enterprise site administrator if the problem persists."}
jq: error (at :3): Cannot index string with string "node"
```

If this occurs, workaround this issue by running the following command — this changes the `ghe-repl-promote` script in place:

```shell
sudo sed -i.bak -e '/for node_hostname in/i if ! $forced; then' -e '/^ done/a fi' /usr/local/bin/ghe-repl-promote
```

Then re-run the updated `ghe-repl-promote` script.