-
Notifications
You must be signed in to change notification settings - Fork 60.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct thanks.dev instructions #35525
Conversation
The current thanks.dev instructions are wrong. This is the correct URL.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Another option would be to leave the FUNDING file example as is, and have GitHub prefix all thanks.dev URLs with |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@vladh Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vladh Thanks for spotting this and raising a fix! I'll get this merged now.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The current thanks.dev instructions are wrong. This is the correct URL.
For example, this goes nowhere: https://thanks.dev/vladh
This goes somewhere: https://thanks.dev/u/gh/vladh
What's being changed (if available, include any code snippets, screenshots, or gifs):
I've only changed the thanks.dev FUNDING file example.
Check off the following: