Add MySQL 8.4 Support #1494
Open
Add MySQL 8.4 Support #1494
+1,437
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chen-anders
requested review from
rashiq,
meiji163 and
timvaillancourt
as code owners
chen-anders
force-pushed
the
anders/mysql-8.4-support
branch
2 times, most recently
from
14607eb to
85b26b7
Compare
chen-anders
force-pushed
the
anders/mysql-8.4-support
branch
from
1b3f7f4 to
769767f
Compare
chen-anders
force-pushed
the
anders/mysql-8.4-support
branch
from
ffc60f3 to
e2114df
Compare
chen-anders
force-pushed
the
anders/mysql-8.4-support
branch
from
e2114df to
7142b2b
Compare
|
Hi @rashiq @meiji163 @timvaillancourt anything else you need for getting this PR in? We're using this as we upgraded our mysql hosts on RDS and would love to see this merged so we don't need to maintain a fork. |
|
Thank you for the PR! It looks good to me! The person who usually cuts the releases for gh-ost is ooo for another few days, so I'll be testing this branch and we'll hopefully have this merged very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1493
Description
MySQL 8.4 deprecates several old-style
master/slavecommands. Unfortunately, we had upgraded our DB to 8.4.3 and then found out after the fact that gh-ost broke, so this PR aims to introduce compatibility across 8.4+.script/cibuildreturns with no formatting errors, build errors or unit test errors.I wasn't able to get a minimal mysql 8.4 tarball that would actually pass the CI tests with dbdeployer but did manage to get the docker version running and passing: https://github.com/chen-anders/gh-ost/actions/runs/13026574857