-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#223) display diff for nested arrays of objects #224
Open
masterzen
wants to merge
8
commits into
github:master
Choose a base branch
from
masterzen:bugfix/223-display-diff-for-nested-arrays-of-objects
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
(#223) display diff for nested arrays of objects #224
masterzen
wants to merge
8
commits into
github:master
from
masterzen:bugfix/223-display-diff-for-nested-arrays-of-objects
Commits on May 14, 2020
-
(github#223) display diff for nested arrays of objects
When using octocatalog-diff with puppet resources with deep nested datastructures such as nested arrays of objects, octocatalog- diff would not display diffs when array elements are modified,added or removed. In fact, it turns out `dig_out_key` doesn't descend into arrays index that hashdiff can produce, like for instance: testtype::test::parameters::testparam::another-one::an-array[0]::env `dig_out_key` would stop at `an-array` because it doesn't know that's and array index it should try to descend into. This patch adds the functionality for `dig_out_key` to follow array index and descend into those nested structure.
Brice Figureau committedMay 14, 2020 Configuration menu - View commit details
-
Copy full SHA for e4c3660 - Browse repository at this point
Copy the full SHA e4c3660View commit details
Commits on Dec 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bc24319 - Browse repository at this point
Copy the full SHA bc24319View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2911ca2 - Browse repository at this point
Copy the full SHA 2911ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cb2c96 - Browse repository at this point
Copy the full SHA 2cb2c96View commit details
Commits on Dec 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 112c364 - Browse repository at this point
Copy the full SHA 112c364View commit details
Commits on Dec 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6b6b7e4 - Browse repository at this point
Copy the full SHA 6b6b7e4View commit details
Commits on Jan 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8cfeee9 - Browse repository at this point
Copy the full SHA 8cfeee9View commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd34209 - Browse repository at this point
Copy the full SHA bd34209View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.