Add GitHub/AvoidObjectSendWithDynamicMethod cop #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new cop to detect when use of Object#send, #public_send, or
__send__
. At first I had the Rubocop flagging every use of a send method, but I scaled that back so the cop is less strict. If the method name being sent is constant, likefoo.send(:bar)
, the cop doesn't complain. The cop also allows for partially dynamic method names, as long as some of the method being sent is constant.Related: