Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrimSpace from string fingerprint before hex.DecodeString #106

Closed
wants to merge 2 commits into from

Conversation

jspraul
Copy link

@jspraul jspraul commented Mar 23, 2022

Rookie passing "-bsau [string fingerprint]" as one parameter when debugging. getopt still worked but didn't trim the leading space from string fingerprint.

The end of email parsing at

name = strings.TrimSpace(id[n.start:n.end])
calls TrimSpaces everywhere so I thought it might be worth doing the same defensively for the string fingerprint.

PS. Both my 👍 👍 's up for pull cgo windows to syscall #93 and @tg123, it's the only reason I'm here.

@jspraul
Copy link
Author

jspraul commented Mar 23, 2022

Sorry, requiring all commits to be signed wasn't mentioned in CONTRIBUTING.md, but it makes sense.

If there's any interest in this at all (very minor issue and tiny fix) I can go through this again, signing commits this time.

@jspraul jspraul closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant