Backport schema reload performance fix #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, obtaining table sizes from mysql involves joining `information_schema.tables`, which can be very costly on systems with a large number of tables. My tests on a system with 13k tables took around 20s without this patch, and only 4s with it. Instead of synchronously recalculating table size stats after every DDL, let them be outdated until the periodic schema reload fixes it. Signed-off-by: pupu <[email protected]> Signed-off-by: pupu <[email protected]>
arthurschreiber
merged commit da6a40c
into
release-15.0-github
214 of 229 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backports a schema reload performance fix created by @pudiva. This fix has already landed in v16 upstream. The reason I'm backporting this is that without this fix, CI for github/github is pretty slow when databases need to be rebuild.
Related Issue(s)
TODO