-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Project Access Tokens #1018
Conversation
@jmini Thank you for your feedback 🙏 . I implemented your suggestions. |
Regarding the failing test case: Some of the API endpoints have been added in GitLab release 14.10 and 16.0 (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/82714 or https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120436). As the tests currently run against GitLab 13.9 the newly added test cases will fail for an obvious reason. |
Yes I think we already did something like that in #963 just adding a There is an idea to switch the GitLab instance that used in the integration tests #925, but I don't know if there are any progress. |
Great. I will add it tomorrow, and then the PR is good to go 😄 |
@jmini I have now commented out the affected lines. Everything works now 👍 |
Merged, thank you very much for this contribution! 🎉 |
For further development within the Artemis project we need project access tokens. Therefore, we implemented the corresponding feature.
This PR adds the methods to interact with the project access tokens API provided by GitLab.
I have tested the newly introduced methods with GitLab version 13.10.
If you have questions, please let us know.
Closes #693