Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

サインアウトモーダルの作成 #76

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

wdtkr
Copy link
Contributor

@wdtkr wdtkr commented Jun 27, 2024

背景

変更点

  • サインアウトモーダルの作成
  • ヘッダーのファイル構造を修正

変更についての説明

実施したテスト

@@ -72,28 +72,24 @@ export const PostDetailRoute = () => {
<Button onClick={onOpen} colorScheme="primary">
削除
</Button>
<>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここの<>が要らないので削除

</Button>
<>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここも

)}
</Box>
</header>
<SignoutModal isOpen={isOpen} onClose={onClose} signoutMutate={signoutMutate} refetch={refetch} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SignoutModalとして切り出し

@@ -0,0 +1 @@
export { Header } from './Header'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headerをインポートするときに ./Header/Header ってなるのが嫌だったので。

@wdtkr wdtkr self-assigned this Jun 27, 2024
@wdtkr wdtkr added the Frontend label Jun 27, 2024
@wdtkr wdtkr requested a review from funobu June 27, 2024 09:11
@wdtkr
Copy link
Contributor Author

wdtkr commented Jun 27, 2024

mainの変更をマージしたのでレビューお願いします!

@wdtkr wdtkr requested a review from hibalikuhina June 27, 2024 09:12
@funobu
Copy link
Contributor

funobu commented Jun 28, 2024

メモ:後でやる

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants