Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement infinite reconnect and cancel. #133

Merged
merged 4 commits into from
Oct 6, 2024
Merged

Implement infinite reconnect and cancel. #133

merged 4 commits into from
Oct 6, 2024

Conversation

gkoh
Copy link
Owner

@gkoh gkoh commented Oct 3, 2024

Enable a user to cancel a connection attempt.

Merge in #132 from @hijae for the settings to control the behaviour.

With this change, the following will occur:

  • with Infinite-ReConnect = OFF
    • furble will attempt a single reconnect on connection drop
    • a successful reconnect will reset the counter
  • with Infinite-ReConnect = ON
    • furble will attempt to reconnect indefinitely, unless Cancel is pressed
    • M5ez menu handling doesn't help us here, the control menu will be shown, but any item press will exit

@gkoh gkoh linked an issue Oct 3, 2024 that may be closed by this pull request
Connection without timeout #129
Closed
@gkoh gkoh mentioned this pull request Oct 3, 2024
Closed
@gkoh
Copy link
Owner Author

gkoh commented Oct 3, 2024

@hijae Please test and ensure things are working as you expect (I changed quite a lot 🫤)

I'm doing a battery life test on an M5StickC Plus2 just to see how long it lasts continuously reconnecting ...

@gkoh gkoh mentioned this pull request Oct 3, 2024
Closed
@gkoh
Copy link
Owner Author

gkoh commented Oct 4, 2024

I'm doing a battery life test on an M5StickC Plus2 just to see how long it lasts continuously reconnecting ...

I managed to get just under 2 hours continuous reconnection.
I'll hack it and see if there's any difference with the backlight completely off.

gkoh and others added 4 commits October 4, 2024 16:13
@gkoh
Implement infinite reconnect with cancel.
99ba761 
Refactor a lot of things to support cancelling an active connection
attempt.
Significantly simplify the callback structure for the connection
progress bar.

Whilst here, fix possible null pointer dereferences in Fujifilm
service and characteristic handling.
@hijae @gkoh
(#129) Reconnect without timeout
8fb37a8
@hijae @gkoh
(#129) Enhance Warning
c629a10
@gkoh
Remove stale warning in README.
29691a3
@gkoh gkoh force-pushed the 129-connection-without-timeout branch from c83fc5e to 29691a3 Compare October 4, 2024 06:43
@gkoh
Copy link
Owner Author

gkoh commented Oct 6, 2024

I'm doing a battery life test on an M5StickC Plus2 just to see how long it lasts continuously reconnecting ...

I managed to get just under 2 hours continuous reconnection. I'll hack it and see if there's any difference with the backlight completely off.

I didn't manage to get to this, I think the warning is sufficient to set poor expectations.
If you really want longevity, I'd suggest the M5Core2 with the 1500mAh battery.

@gkoh gkoh merged commit 58d216f into master Oct 6, 2024
5 checks passed
@gkoh gkoh deleted the 129-connection-without-timeout branch October 6, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection without timeout
2 participants
@gkoh @hijae