67 add advanced interval shutter release #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add random test code to demo what it looks like.
Whilst here, fix a major bug in our M5ez button display code. This was causing a crash at certain times.
Refactor the interval code to its own files.
|
@matthudsonau I think this is ready to be tested. Changes since the discussion in the issue:
Intervalometer settings are only in the 'Interval' menu after connecting, for now. |
|
The change is kinda large because I refactored things out and needed to clean up the mess. |
|
Looks good at first glance, ran through a few different combinations and seemed to work fine. Only potential issue is a flickering display when the intervalometer is running, but I'll see if I can track down the cause of that |
gkoh
commented
Mar 7, 2024
Only redraw the lines if they change and msgBox has been asked to avoid a full clear/redraw.
Intervalometer settings can now be configured in both 'Settings' and the 'Interval' menu.
|
With d2c0efb the intervalometer configuration now appears in both the 'Interval' and 'Settings' menus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following: