Fix GPS geotag support for different firmware versions. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gkoh
force-pushed
the
95-gfx100ii-gps-not-working
branch
from
509d6a1 to
7659901
Compare
gkoh
changed the title
gkoh
force-pushed
the
95-gfx100ii-gps-not-working
branch
from
eff33d8 to
743d8a4
Compare
Reading the spec, the 16-bit handle is only consistent per device instance. Thus, it can change between devices and firmware versions. The full UUID is guaranteed to be consistent, so use that instead.
ez.yield() already calls M5.update(). Remove the delay(50), this buys us nothing (except UI latency).
gkoh
force-pushed
the
95-gfx100ii-gps-not-working
branch
from
622e224 to
8b2dc91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the 128-bit UUID for geotag characteristic.
The 16-bit handle is not consistent across devices or firmware versions.