Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using bytes_tree and string_tree instead of *_builder #104

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Using bytes_tree and string_tree instead of *_builder #104

merged 3 commits into from
Nov 21, 2024

Conversation

GiregL
Copy link
Contributor

@GiregL GiregL commented Nov 19, 2024

This PR changes the *_builder modules to *_tree modules in the WISP code, as well as updating the stdlib dependency.

lpil
lpil reviewed Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab, thank you!

I think you'll need to update the examples too

gleam.toml Outdated Show resolved Hide resolved
Lezenn and others added 2 commits November 20, 2024 16:41
lpil
lpil approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@lpil lpil merged commit c8fab55 into gleam-wisp:main Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiregL @lpil