Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpunit/phpunit requirement from ^10.0 to ^10.0 || ^11.0 #24

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 21, 2024

Updates the requirements on phpunit/phpunit to permit the latest version.

Release notes

Sourced from phpunit/phpunit's releases.

PHPUnit 11.0.7

Changed

  • #5747: Cache result of Groups::groups()
  • #5748: Improve performance of NamePrettifier::prettifyTestMethodName()
  • #5750: Micro-optimize NamePrettifier::prettifyTestMethodName() once again
  • #5752: Improve message for deprecation of doubling methods named "method"

Fixed

  • #5760: TestDox printer does not display details about exceptions raised in before-test methods

How to install or update PHPUnit

Changelog

Sourced from phpunit/phpunit's changelog.

[11.0.7] - 2024-03-21

Changed

  • #5747: Cache result of Groups::groups()
  • #5748: Improve performance of NamePrettifier::prettifyTestMethodName()
  • #5750: Micro-optimize NamePrettifier::prettifyTestMethodName() once again
  • #5752: Improve message for deprecation of doubling methods named "method"

Fixed

  • #5760: TestDox printer does not display details about exceptions raised in before-test methods

[11.0.6] - 2024-03-12

Changed

  • #5727: Prevent duplicate call of NamePrettifier::prettifyTestMethodName()
  • #5739: Micro-optimize NamePrettifier::prettifyTestMethodName()
  • #5740: Micro-optimize TestRunner::runTestWithTimeout()
  • #5741: Save call to Telemetry\System::snapshot()
  • #5742: Prevent file IO when not strictly necessary
  • #5743: Prevent unnecessary ExecutionOrderDependency::getTarget() call
  • #5744: Simplify NamePrettifier::prettifyTestMethodName()

Fixed

  • #5351: Incorrect code coverage metadata does not prevent code coverage data from being collected
  • #5729: assertArrayIsIdenticalToArrayOnlyConsideringListOfKeys() does not correctly handle array order
  • #5746: Using -d CLI option multiple times triggers warning

[11.0.5] - 2024-03-09

Fixed

  • #5652: HRTime::duration() throws InvalidArgumentException
  • --exclude-filter CLI option does not work

[11.0.4] - 2024-02-29

Fixed

  • #5704: No warning when CLI options are used multiple times
  • #5707: --fail-on-empty-test-suite CLI option is not documented in --help output
  • #5716: Better respect PHP native array key handling for assertArrayIs*ToArrayOnlyConsideringListOfKeys()

[11.0.3] - 2024-02-10

Changed

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) to permit the latest version.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases)
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/11.0.7/ChangeLog-11.0.md)
- [Commits](sebastianbergmann/phpunit@10.0.0...11.0.7)

---
updated-dependencies:
- dependency-name: phpunit/phpunit
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Mar 21, 2024
@brother brother requested review from a team, brother, olyckne, ttrig, hejhansson, olvert, christofferlindstrom and Enstorkaffe and removed request for a team March 25, 2024 09:43
@brother
Copy link
Member

brother commented Mar 25, 2024

Seems like a minor thing to go to 11 \m/.

Any thoughts?

brother ~/git/github/butler-health (dependabot/composer/phpunit/phpunit-tw-10.0or-tw-11.0)$ ./vendor/bin/phpunit 
PHPUnit 11.0.8 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.17
Configuration: /home/brother/git/github/butler-health/phpunit.xml

...........SS.....................                                34 / 34 (100%)

Time: 00:01.311, Memory: 30.00 MB

There were 9 PHPUnit test runner deprecations:

1) Metadata found in doc-comment for method GrahamCampbell\TestBench\AbstractPackageTestCase::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

2) Metadata found in doc-comment for method Butler\Tests\Health\DatabaseCheckTest::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

3) Metadata found in doc-comment for method Butler\Health\Tests\FailedJobsCheckTest::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

4) Metadata found in doc-comment for method Butler\Tests\Health\RedisCheckTest::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

5) Metadata found in doc-comment for method Butler\Health\Tests\Feature\RouteTest::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

6) Metadata found in doc-comment for method Butler\Health\Tests\HeartbeatTest::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

7) Metadata found in doc-comment for method Butler\Health\Tests\HelpersTest::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

8) Metadata found in doc-comment for method Butler\Health\Tests\RepositoryTest::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

9) Metadata found in doc-comment for method Butler\Health\Tests\ServiceProviderTest::tearDownMockery(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

OK, but there were issues!
Tests: 34, Assertions: 109, Deprecations: 9, Skipped: 2.

@ttrig ttrig closed this Mar 25, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 25, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/composer/phpunit/phpunit-tw-10.0or-tw-11.0 branch March 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants