handshake timeout #204
Merged
handshake timeout #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aderouineau
force-pushed
the
handshaketimeout
branch
from
4047bd4 to
5f2f617
Compare
|
seems ok to me |
|
Any update on getting this merged? |
gustavosbarreto
requested changes
Oct 4, 2023
aderouineau
force-pushed
the
handshaketimeout
branch
from
5f2f617 to
3004d15
Compare
|
@gustavosbarreto Added a unit test and reworded the commit message. |
aderouineau
force-pushed
the
handshaketimeout
branch
from
3004d15 to
ccf6f02
Compare
…ed within the duration HandshakeTimeout
aderouineau
force-pushed
the
handshaketimeout
branch
from
ccf6f02 to
2326046
Compare
|
Any update on this review? |
|
@belak @gustavosbarreto This PR has been sitting for 6 months now. Does anything else need to be addressed, or can it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to time out a connection if a successful handshake has not happened within the duration
HandshakeTimeout.