-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DefaultServerConfigCallback option for create custom default ServerConfig
s
#95
Add DefaultServerConfigCallback option for create custom default ServerConfig
s
#95
Conversation
LGTM |
Huh, interesting. I like this approach. This would also replace #86 |
Alternatively, this could be done by adding a config hook which would take a context and the ServerConfig and allow the user to modify it before actually using it. |
I didn't see that #86 existed. Whatever you guys think is best. :-) |
I like callbacks. Eventually will clean up the API into single delegate that can implement various interfaces. We/somebody can change this to pass in a default config later. |
Awesome. You guys are super quick. How long does it usually take to get things merged / into a tag? |
I'd have merged already if @belak explicitly gave thumbs up. Tagging is done by request right now. |
As long as we understand that the API may change later, I'm fine with this in its current form. It looks good to me! |
Pre-1.0 the API will be changing a lot |
Then I'm good with this. 👍 from me! |
Awesome thanks guys. Thank was so quick! |
Tagged as v0.1.3. Thanks for contributing! |
This callback allows a more granular control of the SSH server configuration, such as for the key exchange / cipher / MAC algorithms.
Example usage: