Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added discord link to the ui-#3007 #3170

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Added discord link to the ui-#3007 #3170

merged 3 commits into from
Dec 15, 2024

Conversation

Vimalnegi03
Copy link
Contributor

@Vimalnegi03 Vimalnegi03 commented Dec 13, 2024

Description

Target issue: #3007

  • Added discord link to the UI below What's New
    al1q6mks

Copy link

github-actions bot commented Dec 13, 2024

@github-actions github-actions bot temporarily deployed to pull request December 13, 2024 10:54 Inactive
Copy link

cypress bot commented Dec 13, 2024

Glific    Run #5462

Run Properties:  status check passed Passed #5462  •  git commit b574c626ec ℹ️: Merge 4ed3ba29c8b97add6fa2210303ac4b693d3e4565 into 3e5857e050f3300e13d812f37f1b...
Project Glific
Branch Review enhancement/discord_ui
Run status status check passed Passed #5462
Run duration 25m 19s
Commit git commit b574c626ec ℹ️: Merge 4ed3ba29c8b97add6fa2210303ac4b693d3e4565 into 3e5857e050f3300e13d812f37f1b...
Committer Vimal Negi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@Vimalnegi03 Vimalnegi03 added the good first issue Good for newcomers label Dec 13, 2024
@Vimalnegi03 Vimalnegi03 self-assigned this Dec 13, 2024
@github-actions github-actions bot temporarily deployed to pull request December 15, 2024 20:00 Inactive
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (d0ae9c1) to head (67bf8da).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3170      +/-   ##
==========================================
- Coverage   81.69%   81.68%   -0.02%     
==========================================
  Files         329      330       +1     
  Lines       10491    10494       +3     
  Branches     2192     2192              
==========================================
+ Hits         8571     8572       +1     
- Misses       1308     1309       +1     
- Partials      612      613       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR @Vimalnegi03

@kurund kurund merged commit bfbb7cc into master Dec 15, 2024
10 of 12 checks passed
@kurund kurund deleted the enhancement/discord_ui branch December 15, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants