Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in hsm template #3192

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Issues in hsm template #3192

merged 3 commits into from
Jan 20, 2025

Conversation

akanshaaa19
Copy link
Member

  1. not being able to apply for media messages
  2. issues with validation- on applying text type template without buttons it fails because of incorrect validation

Copy link

github-actions bot commented Jan 16, 2025

@github-actions github-actions bot temporarily deployed to pull request January 16, 2025 09:44 Inactive
@akanshaaa19 akanshaaa19 self-assigned this Jan 16, 2025
@github-actions github-actions bot temporarily deployed to pull request January 16, 2025 09:51 Inactive
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.76%. Comparing base (e20e313) to head (ccdd416).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/HSM/HSM.tsx 60.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3192      +/-   ##
==========================================
- Coverage   81.83%   81.76%   -0.08%     
==========================================
  Files         327      327              
  Lines       10540    10543       +3     
  Branches     2177     2179       +2     
==========================================
- Hits         8625     8620       -5     
- Misses       1304     1310       +6     
- Partials      611      613       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 16, 2025

Glific    Run #5531

Run Properties:  status check passed Passed #5531  •  git commit c5ebdb1f23 ℹ️: Merge ccdd416d61dcbda2a204877545d6e894864f2768 into e20e3130916939cc0101a1c036dc...
Project Glific
Branch Review hsm-template-fixes
Run status status check passed Passed #5531
Run duration 25m 33s
Commit git commit c5ebdb1f23 ℹ️: Merge ccdd416d61dcbda2a204877545d6e894864f2768 into e20e3130916939cc0101a1c036dc...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 172
View all changes introduced in this branch ↗︎

@akanshaaa19 akanshaaa19 requested a review from kurund January 16, 2025 14:29
@akanshaaa19 akanshaaa19 requested review from kurund and removed request for kurund January 16, 2025 14:35
@github-actions github-actions bot temporarily deployed to pull request January 20, 2025 07:41 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic looks good. However, I was not able to replicate the issue.

@kurund kurund merged commit 57ec319 into master Jan 20, 2025
10 of 12 checks passed
@kurund kurund deleted the hsm-template-fixes branch January 20, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants