Skip to content

Commit

Permalink
chore: minor review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
stephanoshadjipetrou committed Mar 7, 2023
1 parent 5cbcde4 commit ab4d6a4
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 34 deletions.
44 changes: 17 additions & 27 deletions src/app/components/PageHeader/components/tabs/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const countryDetailTabs: TabProps[] = [
tabs: [
{
name: "Eligibility",
url: "/location/<code>/eligibility",
url: "/location/<code>/eligibility/table",
},
{
name: "Allocation",
Expand Down Expand Up @@ -58,17 +58,12 @@ export const countryDetailTabs: TabProps[] = [
],
},
{
name: "More",
tabs: [
{
name: "Results",
url: "/location/<code>/results",
},
{
name: "Documents",
url: "/location/<code>/documents",
},
],
name: "Results",
url: "/location/<code>/results",
},
{
name: "Documents",
url: "/location/<code>/documents",
},
];

Expand Down Expand Up @@ -99,21 +94,16 @@ export const grantDetailTabs: TabProps[] = [
],
},
{
name: "More",
tabs: [
{
name: "Performance Rating",
url: "/grant/<code>/<period>/performance-rating",
},
{
name: "Targets and Results",
url: "/grant/<code>/<period>/targets-results",
},
{
name: "Documents",
url: "/grant/<code>/<period>/documents",
},
],
name: "Performance Rating",
url: "/grant/<code>/<period>/performance-rating",
},
{
name: "Targets and Results",
url: "/grant/<code>/<period>/targets-results",
},
{
name: "Documents",
url: "/grant/<code>/<period>/documents",
},
];

Expand Down
13 changes: 9 additions & 4 deletions src/app/components/ToolBoxPanel/utils/getControlItems.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ const views = {
value: "Map",
link: "/viz/allocations/map",
},
{
label: "Table",
value: "Table",
link: "/viz/allocations/table",
},
],
grants: [
{
Expand Down Expand Up @@ -181,14 +186,14 @@ const aggregates = {
// },
// ],
eligibility: [
{
label: "Components",
value: "componentName",
},
{
label: "Locations",
value: "geographicAreaName",
},
{
label: "Components",
value: "componentName",
},
],
};

Expand Down
2 changes: 1 addition & 1 deletion src/app/hooks/useDatasetMenuItems.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export function useDatasetMenuItems(): React.ReactChild[] {
</Link>
</Expandable>,
<Expandable label="Access to Funding">
<Link to={`/viz/eligibility${location.search}`}>Eligibility</Link>
<Link to={`/viz/eligibility/table${location.search}`}>Eligibility</Link>
<Link to={`/viz/allocations${location.search}`}>Allocations</Link>
</Expandable>,
<Expandable label="Grant Implementation">
Expand Down
2 changes: 1 addition & 1 deletion src/app/modules/datasets-module/data.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const datasets: DatasetItemModel[] = [
},
{
name: "Eligibility",
link: "/viz/eligibility",
link: "/viz/eligibility/table",
group: "Access to Funding",
preview: <EligibilityDotsPreview />,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export function LandingDatasetGrid() {
<Grid item xs={12} sm={6} md={6} lg={3}>
<GridItem
title={aeText}
link="/viz/eligibility"
link="/viz/eligibility/table"
description={aeDescription}
iconLinks={[
{
Expand Down Expand Up @@ -254,6 +254,10 @@ export function LandingDatasetGrid() {
icon: <MapIcon />,
link: "/viz/allocations/map",
},
{
icon: <TableIcon />,
link: "viz/allocations/table",
},
]}
/>
</Grid>
Expand Down

0 comments on commit ab4d6a4

Please sign in to comment.