Included junit test case for connect exception and plugin was updated…

… accordingly
globocom · Oct 27, 2020 · 5167356 · 5167356
1 parent a1ac883
commit 5167356
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/networkapi/plugins/Juniper/JUNOS/plugin.py b/networkapi/plugins/Juniper/JUNOS/plugin.py
@@ -91,7 +91,7 @@ def connect(self):
 
         except ConnectError as e:
             log.error("Could not connect to Juniper host {}: {}".format(self.equipment_access.fqdn, e))
-            raise ConnectError
+            raise ConnectError(e)
 
         except Exception, e:
             log.error("Unknown error while connecting to host {}: {}".format(self.equipment_access.fqdn, e))

diff --git a/networkapi/plugins/Juniper/JUNOS/tests.py b/networkapi/plugins/Juniper/JUNOS/tests.py
@@ -1,8 +1,8 @@
 from networkapi.test.test_case import NetworkApiTestCase
 from networkapi.plugins.base import BasePlugin
 from networkapi.plugins.Juniper.JUNOS.plugin import JUNOS
-import mock
 from mock import patch, MagicMock
+from jnpr.junos.exception import ConnectError, LockError
 
 
 class JunosPluginTest(NetworkApiTestCase):
@@ -64,6 +64,16 @@ def test_connect_success(self, mock_device):
         self.assertIsNotNone(plugin.configuration)
         self.assertEqual(connection_response, True)
 
+    def test_connect_wrong_data_exception(self):
+
+        """
+        test_connect_wrong_data_exception
+        """
+
+        plugin = JUNOS(equipment_access=self.mock_equipment_access)
+        with self.assertRaises(ConnectError):
+            plugin.connect()
+
     @patch('jnpr.junos.utils.config.Config')
     def test_exec_command_success(self, mock_config):