Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff cleanup #337

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Ruff cleanup #337

merged 8 commits into from
Nov 20, 2023

Conversation

daveisfera
Copy link
Contributor

Cleans up the issues found by ruff after the changes from #336

@mauricioabreu
Copy link
Member

That's HUGE! 👏🏼

Thank you!

@mauricioabreu
Copy link
Member

@daveisfera could you solve these conflicts? I think they were raised from your previous contributions

@daveisfera
Copy link
Contributor Author

@daveisfera could you solve these conflicts? I think they were raised from your previous contributions

Done

@daveisfera
Copy link
Contributor Author

I added an action to run ruff on pushes and pull requests

@daveisfera
Copy link
Contributor Author

Could this PR and the others I submitted (#334 #335 #339) be merged? I'd love to get a release with these improvements out there (especially performance improvement that was already merged #336)

@mauricioabreu
Copy link
Member

@daveisfera yes. Could you rebase your PR against master? Then I will merge it.

@daveisfera
Copy link
Contributor Author

Rebased and could #345 be merged as well so timespec can be used at the top level?
Thanks for all of your work on this project!

@mauricioabreu mauricioabreu merged commit d260636 into globocom:master Nov 20, 2023
7 checks passed
@mauricioabreu
Copy link
Member

@daveisfera thank you for all your recent contributions. It means a lot.

@daveisfera
Copy link
Contributor Author

daveisfera commented Nov 20, 2023

@daveisfera thank you for all your recent contributions. It means a lot.

Added one more to keep formatting consistent with ruff:
#346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants