Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Bitrate value as integer not string #379

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

davemevans
Copy link
Contributor

See #376.

Would break people who are doing data["segments"][0]["bitrate"] == "1674" (which is the intention), because we wish bitrate to be int.

Would also break people who are doing obj.segments[0].bitrate = "9876" because dumps explicitly requires int now, which I think is fine but could be changed to be more lenient.

@mauricioabreu
Copy link
Member

Thank you @davemevans nice fix.

Since it breaks users of m3u8, I'm going to release a major version again.

@mauricioabreu mauricioabreu merged commit 95455bc into globocom:master Aug 7, 2024
8 checks passed
@davemevans davemevans deleted the ParseBitrateAsInt branch September 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants