Parse Bitrate value as integer not string #379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #376.
Would break people who are doing
data["segments"][0]["bitrate"] == "1674"
(which is the intention), because we wish bitrate to beint
.Would also break people who are doing
obj.segments[0].bitrate = "9876"
becausedumps
explicitly requiresint
now, which I think is fine but could be changed to be more lenient.