Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimizaiton on imageblock component #406

Closed
wants to merge 1 commit into from
Closed

Minor optimizaiton on imageblock component #406

wants to merge 1 commit into from

Conversation

jerempy
Copy link

@jerempy jerempy commented Oct 13, 2022

Related Issue

#384

Proposed Changes

Just some minor improvements to these components

Noticed it while I was looking around to try to solve the above linked issue

@jerempy jerempy mentioned this pull request Oct 13, 2022
Open
lucianapepelucio
lucianapepelucio reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@lucianapepelucio lucianapepelucio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Something went wrong in component 'image'. ReferenceError: props is not defined (ImageBlock.js)
  • ReferenceError: React is not defined (ImageButton.js)

@jerempy
Copy link
Author

jerempy commented Oct 17, 2022

  • Something went wrong in component 'image'. ReferenceError: props is not defined (ImageBlock.js)

    • ReferenceError: React is not defined (ImageButton.js)

thanks! good catch. I'll just close this PR then

@jerempy jerempy closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianapepelucio lucianapepelucio lucianapepelucio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerempy @lucianapepelucio