Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conda lock files and micromamba in place of docker images #1816

Merged
merged 28 commits into from
Jun 19, 2024

Conversation

joaander
Copy link
Member

@joaander joaander commented Jun 13, 2024

Description

  • Rewrite the workflows to use conda lock files and micromamba to provide most build/test dependencies.
  • Remove tests on old compilers.
  • Remove CI checks with ENABLE_LLVM=on.
  • Checks no longer fail when the validate label is not set. Though validate should still be set on most PRs to ensure the validation tests pass.

The docker container images now provide compilers only.

Motivation and context

Allows targeted changes (e.g. testing with numpy 2.0) to be made locally.

ENABLE_LLVM=on will soon be removed. It is not feasible to test this as compilers provided in the conda environment do not generate valid builds.

How has this been tested?

CI checks.

Change log

Internal change, not required.

Checklist:

Provide CI build/test dependencies via conda lock files.
@joaander joaander requested review from a team, tcmoore3 and SchoeniPhlippsn and removed request for a team June 13, 2024 11:38
@joaander joaander force-pushed the refactor-more-ci branch 3 times, most recently from 2615523 to eb73a8a Compare June 13, 2024 12:24
@joaander joaander force-pushed the refactor-more-ci branch 7 times, most recently from 52f4aec to dcb164d Compare June 13, 2024 13:12
@joaander joaander requested review from a team and rayasare and removed request for a team June 13, 2024 14:07
@joaander joaander force-pushed the refactor-more-ci branch 5 times, most recently from 522011e to 9b4acb5 Compare June 19, 2024 00:53
@joaander joaander force-pushed the refactor-more-ci branch 2 times, most recently from 4f617b1 to c3cf643 Compare June 19, 2024 01:26
@joaander joaander force-pushed the refactor-more-ci branch 2 times, most recently from c525d08 to 1d5b760 Compare June 19, 2024 12:44
Add commented code that installs cupy. However, we need the latest cupy
to test with numpy 2.0 - and the latest cupy doesn't support V100.
@joaander joaander added validate Execute long running validation tests on pull requests release Build and unit test all support compiler/python configurations labels Jun 19, 2024
@joaander joaander merged commit 73cd67c into trunk-minor Jun 19, 2024
60 checks passed
@joaander joaander deleted the refactor-more-ci branch June 19, 2024 16:12
joaander added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Build and unit test all support compiler/python configurations validate Execute long running validation tests on pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant