-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Also apply typos in pre-commit and clean up many MD links.
- Loading branch information
Showing
12 changed files
with
150 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
# Contributing | ||
|
||
Contributions are welcomed via [pull requests on GitHub][github]. Contact the **row** | ||
developers before starting work to ensure it meshes well with the planned development | ||
direction and standards set for the project. | ||
|
||
[github]: https://github.com/glotzerlab/gsd/row | ||
|
||
## Features | ||
|
||
### Implement functionality in a general and flexible fashion | ||
|
||
New features should be applicable to a variety of use-cases. The **row** developers can | ||
assist you in designing flexible interfaces. | ||
|
||
### Maintain performance of existing code paths | ||
|
||
Expensive code paths should only execute when requested. | ||
|
||
## Version control | ||
|
||
### Base your work off the correct branch | ||
|
||
- Base all new work on `trunk`. | ||
|
||
### Propose a minimal set of related changes | ||
|
||
All changes in a pull request should be closely related. Multiple change sets that are | ||
loosely coupled should be proposed in separate pull requests. | ||
|
||
### Agree to the Contributor Agreement | ||
|
||
All contributors must agree to the Contributor Agreement before their pull request can | ||
be merged. | ||
|
||
### Set your git identity | ||
|
||
Git identifies every commit you make with your name and e-mail. [Set your identity][id] | ||
to correctly identify your work and set it identically on all systems and accounts where | ||
you make commits. | ||
|
||
[id]: http://www.git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup | ||
|
||
## Source code | ||
|
||
### Use a consistent style | ||
|
||
The **Code style** section of the documentation sets the style guidelines for **row** | ||
code. | ||
|
||
### Document code with comments | ||
|
||
Use **Rust** documentation comments for classes, functions, etc. Also comment complex | ||
sections of code so that other developers can understand them. | ||
|
||
### Compile without warnings | ||
|
||
Your changes should compile without warnings. | ||
|
||
## Tests | ||
|
||
### Write unit tests | ||
|
||
Add unit tests for all new functionality. | ||
|
||
### Validity tests | ||
|
||
The developer should run research-scale simulations using the new functionality and | ||
ensure that it behaves as intended. When appropriate, add a new test to `validate.py`. | ||
|
||
## User documentation | ||
|
||
### Write user documentation | ||
|
||
Document all new configuration keys, command line options, command line tools, | ||
and any important user-facing change in the mdBook documentation. | ||
|
||
### Tutorial | ||
|
||
When applicable, update or write a new tutorial. | ||
|
||
|
||
### Add developer to the credits | ||
|
||
Update the contributors documentation to name each developer that has contributed to the | ||
code. | ||
|
||
### Propose a change log entry | ||
|
||
Propose a short concise entry describing the change in the pull request description. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,30 @@ | ||
# Code style | ||
|
||
**Row** code follows the | ||
[Rust style guide](https://doc.rust-lang.org/style-guide/index.html). | ||
## Rust | ||
|
||
**Row's** [pre-commit](https://pre-commit.com/) configuration applies style fixes | ||
with `rustfmt` checks for common errors with `clippy`. | ||
**Row's** rust code follows the [Rust style guide][1]. **Row's** [pre-commit][2] | ||
configuration applies style fixes with `rustfmt` checks for common errors with `clippy`. | ||
|
||
[1]: https://doc.rust-lang.org/style-guide/index.html | ||
[2]: https://pre-commit.com/ | ||
|
||
## Python | ||
|
||
**Row's** pre-commit configuration both formats and checks Python code with `ruff`. | ||
|
||
## Markdown | ||
|
||
Wrap **Markdown** files at 88 characters wide, except when not possible (e.g. when | ||
formatting a table). Follow layout and design patterns established in existing markdown | ||
files. | ||
|
||
## Spelling/grammar | ||
|
||
Contributors **must** configure their editors to perform spell checking (and preferably | ||
grammar checking as well). **Row's** pre-commit runs | ||
[typos](https://github.com/crate-ci/typos) which has a low rate of false positives. | ||
Developers *should* also configure a more thorough checker of their choice to ensure | ||
that code comments and documentation are free of errors. Suggested tools: | ||
* [typos](https://github.com/crate-ci/typos) | ||
* [ltex-ls](https://github.com/valentjn/ltex-ls) | ||
* [cspell](https://cspell.org/) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters