Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace_path and JSON pointer command template parameters. #53

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

joaander
Copy link
Member

@joaander joaander commented Oct 23, 2024

Description

Allow row to generate commands directly for command line applications. Also properly escape all user-provided strings that are placed in bash scripts.

Motivation and context

Previously, users needed to write a wrapper script in Python that parsed the JSON file and then called subprocess.run.

Resolves #51

How has this been tested?

Extensive unit tests.

Checklist:

  • I have reviewed the Contributor Guidelines.
  • I agree with the terms of the Row Contributor Agreement.
  • My name is on the list of contributors (doc/src/contributors.md) in the pull request source branch.
  • I have added a change log entry to doc/src/release-notes.md.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Nov 21, 2024
@joaander joaander removed the stale label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve support for command line applications
1 participant