Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pending reason notification events #18162

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add pending reason notification events #18162

merged 1 commit into from
Jan 16, 2025

Conversation

cconard96
Copy link
Contributor

Fixes !34694

Add ITIL notification events for:

  • Adding pending reason to ITIL item
  • Removing pending reason from ITIL item
  • ITIL item closed automatically from pending reason

The following event already existed:

  • Automatic reminder

AdrienClairembault
AdrienClairembault requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be tested ?

@cconard96
Copy link
Contributor Author

cconard96 commented Oct 30, 2024 •
edited
Loading

Well its broken anyways. Not that I've ever had notifications set up and working properly.
Its just really sketchy on my installation.

@cconard96 cconard96 force-pushed the feature/pendingreason_notif_events branch from 16e0541 to cc3ecd3 Compare October 31, 2024 09:55
@cconard96 cconard96 force-pushed the feature/pendingreason_notif_events branch from cc3ecd3 to e3da24d Compare January 14, 2025 23:06
@cedric-anne cedric-anne force-pushed the feature/pendingreason_notif_events branch from e3da24d to 4b3ee19 Compare January 16, 2025 12:35
@cedric-anne cedric-anne added this to the 11.0.0 milestone Jan 16, 2025
@cedric-anne cedric-anne merged commit cd1e984 into glpi-project:main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

@trasher trasher trasher approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cconard96 @trasher @cedric-anne @AdrienClairembault