Enhance CSRF handling of AJAX endpoints #18723
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
approved these changes
Jan 14, 2025
AdrienClairembault
approved these changes
Jan 14, 2025
|
Web tests are failing |
Yes, I have some more changes to do. I am putting this PR back in draft for now. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
GLPI has currently a distinct CSRF check logic for AJAX endpoint. Indeed, for these specific endpoints, a CSRF token can be consumed multiple times, see 93750ea
The propose change permits to consider that a request is an AJAX request when the
X-Requested-With: XMLHttpRequestis used (it is commonly used as a flag to mark AJAX requests by the popular JS frameworks), instead of checking tha the request is made on a/ajax/xxxpath.The idea is to permit to use any URL pattern for AJAX endpoints.