-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to "Copy to Clipboard" wrapper #18846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work great so far.
A few places where the new wrapper can also be applied:
- My settings (from top right menu)
- Setup > general > Api (token)
Hello @orthagh, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Checklist before requesting a review
Please delete options that are not relevant.
URL: https://glpi.example.com/front/user.form.php?id=1
Before this PR:
After this PR:
This PR uses the
input-group
class of bootstrap as used on Data Picker inputs to position the "Copy to clipboard" button, as it seems a little misaligned. It works exactly as it is today, allowing copy by clicking into the input or copy button.This PR keeps the current behavior/compatibility to plug-ins that may use the
<div class="copy_to_clipboard_wrapper"></div>
as it is today.It adds a change effect similar to the "Copy to clipboard" on Debug, which changes the icon from "check" to the copy button again to user know it can copy the same information more than once if wanted.
Description
Screenshots (if appropriate):