-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add ticket content from promoted followup #19040
base: 10.0/bugfixes
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right to me. The goal is to only handle overriding the content during the initial form load when creating a ticket. Normally, nothing is in the saved input when the form first loads. With these changes, it looks like it is only an "initial creation" after the form reloads from something like changing the category.
I don’t think the bug related to the category not being selected is due to the fact that the promoted item identifier (_promoted_fup_id) is not present in the URL. When the user clicks on the "Promote to ticket" button, the _promoted_fup_id is added to the URL and saved in a hidden field of the form. This allows, when the page is reloaded (following the change of category), not to lose the tracking ID that has been promoted as a ticket. This PR for attempts to fix the bug in GLPI 10.0.18, which prevents the conversion of a follow-up into a ticket. This issue prevents the ticket description, as well as the person who wrote the follow-up, from going back to the creation form and linking to the original ticket. |
Its my fault for not adding an E2E test for my PR, but I think we need tests now to ensure all issues are fixed:
|
#18611 target bugfixes too |
Okay, your PR is now in |
@MyvTsv, |
Description
Screenshots (if appropriate):