Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multistep validation/approval #19069

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

SebSept
Copy link
Contributor

@SebSept SebSept commented Feb 26, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • we move the "State" (Minimum validation required) into the dropdown setup; each step can have a different % required
  • at install/update, we create a default step named "Validation" and we set the value of a column validation_percent to 100%
  • A validation request can be added from the ticket creation form (technician one). We should keep that, and use the default step automatically.
  • The dropdown will have a is_default column to preselect the step value in the validation forms and to manage the possible absence of choice (missed scenario, like API for example) (column added, field not yet in forms (not implemented)
  • We need to forbid deletion of the last step entry for this dropdown, as we no longer have a global validation percent.

Display-wise:

  • we group the validation table in steps (with thead tags)
    (image)
  • We add progress bars to represent the advancement against the validation percent required for the step
  • granted part is green and placed on the left
  • waiting part is orange and placed in the middle
  • refused part is red and placed on the right
  • we display a goal bar to represent the percentage setup in the step dropdown
  • a tooltip will explain the required percentage to validate the step
  • Approval status field:
  • we remove the text
  • we use one icon for each step where a request exists and add a tooltip with the step and the validation status

@SebSept SebSept self-assigned this Feb 27, 2025
@SebSept SebSept force-pushed the validation-approval-for-tickets-part2-multistep branch 6 times, most recently from 10d45d4 to 82e20f0 Compare March 5, 2025 16:21
@SebSept SebSept force-pushed the validation-approval-for-tickets-part2-multistep branch from 82e20f0 to 48d98b1 Compare March 6, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants