feat(forms): Implement form targets migration

[ccailly]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.

Description

Implement form targets migration

[cedric-anne]

OK for me, but I have 2 remarks.

1. Having some code dedicated to form migrations directly inside the Glpi\Form namespace is probably not the best option. Indeed, the migration code is not supposed to change, and we will want to remove it easilly in a few years, when we will drop the support of GLPI 10.0 in out migration files. Moving all the related code in a Glpi\Migration\Formcreator namespace would be interesting.

2. With your current logic, if a form is considered as outdated during the import operation, it will not be updated, to keep the GLPI version that is more recent, but you will still try to import its child items (questions, destinations, ...). In Command to create generic assets from genericobject plugin data #19033, I handled this way :

foreach ($raw_forms as $raw_form) {
    $reconciliation_criteria = [
        'name'                => $raw_form['name'],
        'entities_id'         => $raw_form['entities_id'],
        'forms_categories_id' => $this->getMappedItemTarget(
            'PluginFormcreatorCategory',
            $raw_form['plugin_formcreator_categories_id']
        )['items_id'] ?? 0,
    ];

    $existing_form = new Form();
    if (
        $existing_form->getFromDBByCrit($reconciliation_criteria)
        && \strtotime($input['date_mod']) < \strtotime($existing_form- >fields['date_mod'])
    ) {
        $this->result->markItemAsReused(Form::class, $existing_form->getID());
        $this->result->addMessage(
            MessageType::Debug,
            sprintf(
                __('%s "%s" (%d) is most recent on GLPI side, its update has been skipped.'),
                Form::getTypeName(1),
                $existing_form->getFriendlyName() ?: NOT_AVAILABLE,
                $existing_form->getID(),
            )
        );
        continue; // and ignore all child imports
    }

    // import the form and all its child items
}

This is more complex on your side, as you are handling child items in a separate loop, but it is probably better to skip child items import if the form is outdated.

Both improvement can be done in separate PRs, if you think their are not intoducing too much complexity.