Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yesno formater in datatable.html.twig #19131

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Mar 4, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • Here is a brief description of what this PR does
    Add a formatter for yes no values such as is_active, is_recursive, etc.

Screenshots (if appropriate):

image

@Lainow Lainow self-assigned this Mar 4, 2025
@Lainow Lainow requested a review from cconard96 March 4, 2025 15:45
@orthagh
Copy link
Contributor

orthagh commented Mar 4, 2025

Could we have nothing for NO choice, and maybe a check icon for YES choice ?

@cconard96
Copy link
Contributor

If we leave it blank for "No" values, I think we need to add something for screen readers to still read it as "No" even if there is nothing visually. Similar for if we use an icon for "Yes", there needs to be an accessible label for it to be read as "Yes".

@Lainow
Copy link
Contributor Author

Lainow commented Mar 4, 2025

Could we have nothing for NO choice, and maybe a check icon for YES choice ?

I think it's weird
image

I find that with a cross for No, it's easier to understand.
image

@cconard96
Copy link
Contributor

There was discussion about this kind of UI in #16721. At least for active/recursive, I think a checkbox for Yes and visually empty for No is OK.

@orthagh
Copy link
Contributor

orthagh commented Mar 4, 2025

I think it's weird

Show the full interface please

@Lainow
Copy link
Contributor Author

Lainow commented Mar 5, 2025

I think it's weird

Show the full interface please

image

Like #16721

@orthagh
Copy link
Contributor

orthagh commented Mar 5, 2025

wait for @cconard96 for validation before merge

@cedric-anne cedric-anne requested a review from cconard96 March 6, 2025 08:56
@cedric-anne cedric-anne merged commit 6d7a26e into glpi-project:main Mar 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants