Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge dropdown display preferences when a dropdown definition is purged #19141

Conversation

cedric-anne
Copy link
Member

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

To manually test #19033 , I sometimes have to delete the imported definition to and run the command to recreate them. I figured out that the dropdown concrete classes display preferences are not deleted when the corresponding dropdown definition is deleted. The result is that I had SQL errors when I reimported a dropdown definition with a previously used system name, due to DB unicity checks.

@cedric-anne cedric-anne self-assigned this Mar 6, 2025
@cedric-anne cedric-anne added the bug label Mar 6, 2025
@cedric-anne cedric-anne added this to the 11.0.0 milestone Mar 6, 2025
@trasher trasher merged commit c1b7ecf into glpi-project:main Mar 6, 2025
9 checks passed
@cedric-anne cedric-anne deleted the 11.0/fix-dropdown-definition-displaypref-purge branch March 6, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants