Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add workflow #117

Merged
merged 9 commits into from
Feb 20, 2024
Merged

chore: Add workflow #117

merged 9 commits into from
Feb 20, 2024

Conversation

nj1973
Copy link
Collaborator

@nj1973 nj1973 commented Feb 15, 2024 •
edited
Loading

Adds three workflows:

  1. Lint the PR title (this cannot be tested on the feature branch, the workflow docs state it only works once on the main branch)
  2. Build the package
  3. Run unit tests on multiple Python versions

Also had to fix a few unit tests.

@nj1973 nj1973 linked an issue Feb 15, 2024 that may be closed by this pull request
Add initial CI/CD workflows #116
Closed
@nj1973 nj1973 changed the title chore: Add workflow badnamechore Add workflow Feb 15, 2024
@nj1973 nj1973 changed the title badnamechore Add workflow chore: Add workflow Feb 16, 2024
@nj1973 nj1973 requested a review from abb9979 February 16, 2024 10:22
abb9979
abb9979 reviewed Feb 20, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
abb9979
abb9979 reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@abb9979 abb9979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete with a few inline comments.

@nj1973 nj1973 requested a review from abb9979 February 20, 2024 15:21
@nj1973 nj1973 merged commit 9935b70 into main Feb 20, 2024
6 checks passed
@nj1973 nj1973 deleted the 116-add-initial-cicd-workflows branch February 20, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abb9979 abb9979 abb9979 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add initial CI/CD workflows
2 participants
@nj1973 @abb9979