Derive Hash for Location struct
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
approved these changes
Mar 18, 2024
|
Only real downside is if the type later gets a field added which doesn't allow |
|
Makes sense, thank you! |
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks so much for this project!
As part of some work in asm-lsp, I found it would be helpful if the
Hashtrait was derived on theLocationstruct, which I've done in this PR.I looked through some of the other types defined in this project and saw that some could have
Hashderived, but others could not as they contain a field of typeserde_json::Value, which does not implementHash. Is there any downside to deriving this trait when possible? I'd be happy to go through and addHashderives as allowed on all structs in the crate if that would be helpful :)