[GR-48651] Ensure that DefaultStackTraceElementObject satisfies the c…

…ontract of InteropLibrary PullRequest: graal/15580
gluonhq · Sep 25, 2023 · 2ae69a8 · 2ae69a8
2 parents 0d620f8 + bb108fa
commit 2ae69a8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/...le.api.exception/src/com/oracle/truffle/api/exception/DefaultStackTraceElementObject.java b/...le.api.exception/src/com/oracle/truffle/api/exception/DefaultStackTraceElementObject.java
@@ -69,8 +69,12 @@ boolean hasExecutableName() {
 
     @ExportMessage
     @TruffleBoundary
-    Object getExecutableName() {
-        return rootNode.getName();
+    Object getExecutableName() throws UnsupportedMessageException {
+        String name = rootNode.getName();
+        if (name == null) {
+            throw UnsupportedMessageException.create();
+        }
+        return name;
     }
 
     @ExportMessage

diff --git a/truffle/src/com.oracle.truffle.api.test/src/com/oracle/truffle/api/test/RootNodeTest.java b/truffle/src/com.oracle.truffle.api.test/src/com/oracle/truffle/api/test/RootNodeTest.java
@@ -264,6 +264,8 @@ static void verifyStackTraceElementGuestObject(Object guestObject) throws Unsupp
         if (interop.hasExecutableName(guestObject)) {
             Object executableName = interop.getExecutableName(guestObject);
             Assert.assertTrue(interop.isString(executableName));
+        } else {
+            AbstractPolyglotTest.assertFails(() -> interop.getExecutableName(guestObject), UnsupportedMessageException.class);
         }
         if (interop.hasDeclaringMetaObject(guestObject)) {
             Object metaObject = interop.getDeclaringMetaObject(guestObject);