Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MegaLinter issues #1390

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Fix MegaLinter issues #1390

merged 4 commits into from
Nov 1, 2023

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Nov 1, 2023

Get rid of annoying issues reported by MegaLinter

Azure VM runner successfully provisioned here:
https://github.com/gluwa/creditcoin/actions/runs/6717685865/job/18256014866?pr=1390

@atodorov atodorov changed the base branch from testnet to dev November 1, 2023 08:43
@atodorov atodorov changed the base branch from dev to testnet November 1, 2023 08:43
@atodorov atodorov force-pushed the fix-megalinter-issues branch from 6a6f630 to 2efa360 Compare November 1, 2023 08:44
@atodorov atodorov changed the base branch from testnet to dev November 1, 2023 08:51
@atodorov atodorov force-pushed the fix-megalinter-issues branch from 2efa360 to 4ee6d14 Compare November 1, 2023 08:51
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Merging #1390 (4aa4987) into dev (b9c00d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1390   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files         110      110           
  Lines       12926    12926           
  Branches      128      128           
=======================================
  Hits         9308     9308           
  Misses       3608     3608           
  Partials       10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atodorov atodorov changed the base branch from dev to testnet November 1, 2023 08:55
@atodorov atodorov force-pushed the fix-megalinter-issues branch 2 times, most recently from 16dc735 to 5d7b0c2 Compare November 1, 2023 08:59
- returns 403 when accessed via bots
- returns 200 when opened in browser
because this feaature isn't enabled on our subscription, see
https://github.com/gluwa/creditcoin/actions/runs/6717567205/job/18255654680?pr=1390

ERROR: {"status":"Failed","error":{"code":"DeploymentFailed","target":"/subscriptions/3d91f14a-f591-496b-a3d1-f198b84caaa3/resourceGroups/github-runner-6717567205-attempt-1/providers/Microsoft.Resources/deployments/runner","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"InvalidParameter","target":"securityProfile.encryptionAtHost","message":"The property 'securityProfile.encryptionAtHost' is not valid because the 'Microsoft.Compute/EncryptionAtHost' feature is not enabled for this subscription."}]}}
@atodorov atodorov changed the base branch from testnet to dev November 1, 2023 09:03
@atodorov atodorov force-pushed the fix-megalinter-issues branch from 5d7b0c2 to 4aa4987 Compare November 1, 2023 09:03
@atodorov atodorov marked this pull request as ready for review November 1, 2023 09:03
Copy link

github-actions bot commented Nov 1, 2023

For full LLVM coverage report click here!

@atodorov atodorov merged commit c1aea43 into dev Nov 1, 2023
36 of 37 checks passed
@atodorov atodorov deleted the fix-megalinter-issues branch November 1, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants