CSUB-882: Fix failing CI jobs & add more asserts #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure why this was removed in 86c777d however it is being imported in unit tests and without it tests are failing to compile
atodorov
changed the title
|
For full LLVM coverage report click here! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1432 +/- ##
==========================================
- Coverage 19.68% 13.68% -6.00%
==========================================
Files 31 31
Lines 1001 1001
Branches 128 128
==========================================
- Hits 197 137 -60
- Misses 794 864 +70
+ Partials 10 0 -10 ☔ View full report in Codecov by Sentry. |
…rrors
RawOrigin::Root yields errors:
Error: Input("Benchmark pallet_creditcoin::burn_all failed: Bad origin")
Error: Input("Benchmark pallet_creditcoin::burn failed: Bad origin")
because the extrinsic signature is checked like so::
let who = ensure_signed(origin)?;
RawOrigin::Root should be used when the extrinsic signature check is::
ensure_root(origin)?;
See for example set_gate_faucet()!
NOTE: always use a multiple of the existential deposit because make_free_balance_be() checks that, see https://paritytech.github.io/polkadot-sdk/master/src/pallet_balances/impl_currency.rs.html#476 The reason we were getting the error: Error: Input("Benchmark pallet_creditcoin::burn failed: BurnInsufficientFunds") is that MIN is 500 and the original chosen value of 100 is lower which causes the check above to fail. WARNING: the values `100` and `500` are in CREDO, not in CTC. That is 10^-18 CTC!
atodorov
force-pushed
the
testing/CSUB-882-fix-failing-ci
branch
from
3aa449e to
6c0b320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Practical tips for PR review & merge: