Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'sudo' argument when creating sudoSigner in tests #1436

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

atodorov
Copy link
Contributor

this improves code readability

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eebe47b) 26.97% compared to head (2c7214c) 70.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1436       +/-   ##
===========================================
+ Coverage   26.97%   70.64%   +43.67%     
===========================================
  Files          31      111       +80     
  Lines        1001    13009    +12008     
  Branches      128      128               
===========================================
+ Hits          270     9190     +8920     
- Misses        721     3819     +3098     
+ Partials       10        0       -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

For full LLVM coverage report click here!

@atodorov atodorov merged commit 2ad4939 into dev Dec 1, 2023
35 of 37 checks passed
@atodorov atodorov deleted the testing/improve-readability-of-test-suite branch December 1, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants