Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-972: Add tests for creditcoin-cli inside the container #1464

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

atodorov
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4141072) 70.64% compared to head (1adc8c5) 71.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1464      +/-   ##
==========================================
+ Coverage   70.64%   71.66%   +1.02%     
==========================================
  Files         111      111              
  Lines       13009    13009              
  Branches      128      128              
==========================================
+ Hits         9190     9323     +133     
+ Misses       3819     3676     -143     
- Partials        0       10      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the testing/cc-cli-in-container branch from 31892fc to 8f2367f Compare December 15, 2023 15:40
@atodorov atodorov force-pushed the testing/cc-cli-in-container branch from 8f2367f to 511b941 Compare December 15, 2023 16:23
@atodorov atodorov force-pushed the testing/cc-cli-in-container branch from 511b941 to 1adc8c5 Compare December 15, 2023 17:06
@atodorov atodorov marked this pull request as ready for review December 15, 2023 17:39
@atodorov atodorov changed the title Add tests for creditcoin-cli inside the container CSUB-972: Add tests for creditcoin-cli inside the container Dec 15, 2023
@atodorov atodorov merged commit 3a1bf6e into dev Dec 18, 2023
36 of 38 checks passed
@atodorov atodorov deleted the testing/cc-cli-in-container branch December 18, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants