Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Node.js v20 before we can upgrade @polkadot dependencies #1504

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Jan 8, 2024

@polkadot/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.20.2"

initially detected in #1445

Copy link

github-actions bot commented Jan 8, 2024

For full LLVM coverage report click here!

pLabarta
pLabarta previously approved these changes Jan 8, 2024
@atodorov atodorov force-pushed the switch_to_nodejs_18 branch from 5be1c0d to a158e5d Compare January 8, 2024 16:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3c9e7d) 71.83% compared to head (68b7005) 71.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1504   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files         111      111           
  Lines       12961    12961           
  Branches      128      128           
=======================================
  Hits         9311     9311           
  Misses       3640     3640           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atodorov atodorov force-pushed the switch_to_nodejs_18 branch from a158e5d to a2ee2db Compare January 9, 2024 09:13
@nathanwhit
Copy link
Contributor

nathanwhit commented Jan 11, 2024

Looks good, not sure whether the CI failures are caused by these changes or if it's unrelated @atodorov.

@atodorov atodorov dismissed stale reviews from pLabarta and zacharyfrederick via 4353ec4 January 12, 2024 08:49
@atodorov atodorov force-pushed the switch_to_nodejs_18 branch from a2ee2db to 4353ec4 Compare January 12, 2024 08:49
@atodorov
Copy link
Contributor Author

Looks good, not sure whether the CI failures are caused by these changes or if it's unrelated @atodorov.

Yeah, IDK about that. Everything appears to loog good still there are 2 important CI jobs which fail. I don't feel comfortable merging this PR just yet.

I'll poke around it a bit more to see if I can find something else.

@atodorov atodorov marked this pull request as draft January 12, 2024 08:50
@polkadot/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.20.2"
@atodorov atodorov force-pushed the switch_to_nodejs_18 branch from 4353ec4 to 68b7005 Compare January 12, 2024 08:53
@atodorov atodorov changed the title Switch to Node.js v18 before we can upgrade @polkadot dependencies Switch to Node.js v20 before we can upgrade @polkadot dependencies Jan 12, 2024
@atodorov atodorov marked this pull request as ready for review January 12, 2024 10:11
@atodorov
Copy link
Contributor Author

Looks good, not sure whether the CI failures are caused by these changes or if it's unrelated @atodorov.

So I switched from Node.js v18 to v20 and both the extrinsics check job and the cli integration test job worked the first time around. Given we're already using v20 for Creditcoin3 I think we can make the switch here too. WDYT ?

@atodorov atodorov merged commit 8d19cbc into dev Jan 15, 2024
36 of 38 checks passed
@atodorov atodorov deleted the switch_to_nodejs_18 branch January 15, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants