-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Node.js v20 before we can upgrade @polkadot dependencies #1504
Conversation
For full LLVM coverage report click here! |
5be1c0d
to
a158e5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1504 +/- ##
=======================================
Coverage 71.83% 71.83%
=======================================
Files 111 111
Lines 12961 12961
Branches 128 128
=======================================
Hits 9311 9311
Misses 3640 3640
Partials 10 10 ☔ View full report in Codecov by Sentry. |
a158e5d
to
a2ee2db
Compare
Looks good, not sure whether the CI failures are caused by these changes or if it's unrelated @atodorov. |
4353ec4
a2ee2db
to
4353ec4
Compare
Yeah, IDK about that. Everything appears to loog good still there are 2 important CI jobs which fail. I don't feel comfortable merging this PR just yet. I'll poke around it a bit more to see if I can find something else. |
@polkadot/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.20.2"
4353ec4
to
68b7005
Compare
So I switched from Node.js v18 to v20 and both the extrinsics check job and the cli integration test job worked the first time around. Given we're already using v20 for Creditcoin3 I think we can make the switch here too. WDYT ? |
@polkadot/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.20.2"
initially detected in #1445