Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSUB-886] Remove PoW Mining References #1505

Merged
merged 13 commits into from
Jan 15, 2024
Merged

[CSUB-886] Remove PoW Mining References #1505

merged 13 commits into from
Jan 15, 2024

Conversation

pLabarta
Copy link
Contributor

@pLabarta pLabarta commented Jan 8, 2024

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@pLabarta
Copy link
Contributor Author

pLabarta commented Jan 8, 2024

Note:

Since the Miner Setup guide was removed and the Node Setup guide was modified. We need to add references to the current docs and update the Node Setup guide output example & instructions to run a persistent local chain.

atodorov
atodorov previously approved these changes Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3baf819) 72.53% compared to head (f2a2b1c) 72.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1505   +/-   ##
=======================================
  Coverage   72.53%   72.53%           
=======================================
  Files         107      107           
  Lines       12561    12561           
  Branches      128      128           
=======================================
  Hits         9111     9111           
  Misses       3440     3440           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 8, 2024

For full LLVM coverage report click here!

@pLabarta pLabarta marked this pull request as ready for review January 8, 2024 15:52
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested.

@pLabarta pLabarta requested a review from atodorov January 12, 2024 16:56
@atodorov atodorov merged commit 92cb56b into dev Jan 15, 2024
35 of 38 checks passed
@atodorov atodorov deleted the 886-rm-pow-refs branch January 15, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants