Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collect coins testnet #1678

Closed
wants to merge 36 commits into from
Closed

Conversation

beqaabu
Copy link
Contributor

@beqaabu beqaabu commented Aug 11, 2024

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@beqaabu beqaabu requested review from atodorov and dlebee August 11, 2024 19:38
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.90%. Comparing base (dc67b19) to head (afb420c).

❗ There is a different number of reports uploaded between BASE (dc67b19) and HEAD (afb420c). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (dc67b19) HEAD (afb420c)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           testnet    #1678       +/-   ##
============================================
- Coverage    72.08%   11.90%   -60.19%     
============================================
  Files          110       30       -80     
  Lines        12873      924    -11949     
  Branches       120      118        -2     
============================================
- Hits          9280      110     -9170     
+ Misses        3583      814     -2769     
+ Partials        10        0       -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beqaabu beqaabu closed this Aug 11, 2024
@beqaabu
Copy link
Contributor Author

beqaabu commented Aug 11, 2024

Closed the pr till morning because the gluwa-bot was pushing an update to weights once every 15 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants