Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collect coins testnet #1681

Closed
wants to merge 32 commits into from
Closed

Conversation

beqaabu
Copy link
Contributor

@beqaabu beqaabu commented Aug 12, 2024

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

Copy link

@DylanVerstraete DylanVerstraete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approving

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the last 7 commits:

image

and let the bot recreate the weights in one sane commit.

Note: the same changes get proposed against dev and will lead to conflicts in the future if left like that.

@beqaabu beqaabu force-pushed the remove-collect-coins-testnet branch from 7c4b240 to 13e1a4d Compare August 12, 2024 09:13
@beqaabu beqaabu requested a review from atodorov August 12, 2024 09:21
@beqaabu
Copy link
Contributor Author

beqaabu commented Aug 12, 2024

Closing in favor of #1684

@beqaabu beqaabu closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants