forked from solidusio/solidus
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GTIN and Condition to variant for structured data use #5
Open
rahulsingh321
wants to merge
1
commit into
gms-electronics:6060-structured-data-products
Choose a base branch
from
rahulsingh321:6060-structured-data-products
base: 6060-structured-data-products
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added GTIN and Condition to variant for structured data use #5
rahulsingh321
wants to merge
1
commit into
gms-electronics:6060-structured-data-products
from
rahulsingh321:6060-structured-data-products
+104
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fthobe
reviewed
Feb 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look
bd12953
to
2136879
Compare
d97fa5a
to
e04f42b
Compare
d6316bd
to
e04f42b
Compare
c8c9ae9
to
e04f42b
Compare
@rahulsingh321 please publish as draft till it's ready for review (tests pass) |
e04f42b
to
fe171d4
Compare
fe171d4
to
fdac605
Compare
fdac605
to
d44a9dd
Compare
d44a9dd
to
53b229a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of Structured Data for Item Condition and Global Trade Item Number ("GTIN").
Contained Information
Introduction
This is the first in a series of PRs to implement full structured data support on Solidus.
Structured Data is the common standard to exchange product and content information via the frontend with search engines and marketing platforms and is defined by the schema.org organisation (through the founding companies Google, Microsoft, Yahoo and Yandex).
It has become the defacto standard to communicate with search engines and also many social networks (such as Facebook).
In this first PR following fields are tackled:
This scope of this PR is not to provide structured data on the frontend but merely to provide the information required to generate fully compliant structured data on frontend and feeds without 3rd party extensions or added fields.
GTIN (frequently also known as UPC / EAN in Europe)
Definition
A unique identifier for products usually given by either the manufacturer or the official distributor of a product. Frequently required to have stock listed with marketplaces. It's usually used to identify a product uniquely across multiple steps in the supply chain. While the GTIN is a unique identifier for a product entity it is in no mean a serial number (eg every iPhone of the same model and configuration sold in one country share the UPC, but not the serial number).
It's frequently used to match products in stock synchronizations or order APIs.
Support
Search Engines
Marketplaces
Search Ads
Item Condition
Definition
The item condition has found wide acceptance over the past years to annotate if a product is
While the origins where originally found in second hand marketplaces and the car industry, it became widely used with the emergence of the circular economy.
Support
Search Engines
Marketplaces
Search Ads
Concerns: solidusio#6060
Screenshots Admin Backend
Product
Variant
APIs
Get Product
Update Product
Possible Improvements